Commit 40c8e6d
net: remove hot path comment from connect
This comment was added with an assumption that we could determine the
IP address that localhost should resolve to without performing a
lookup. This was a false assumption and should be removed.
PR-URL: #4648
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>1 parent 9ca24de commit 40c8e6d
1 file changed
Lines changed: 0 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -931,7 +931,6 @@ function lookupAndConnect(self, options) { | |||
| 931 | 931 | port |= 0; | |
| 932 | 932 | ||
| 933 | 933 | // If host is an IP, skip performing a lookup | |
| 934 | - // TODO(evanlucas) should we hot path this for localhost? | ||
| 935 | 934 | var addressType = exports.isIP(host); | |
| 936 | 935 | if (addressType) { | |
| 937 | 936 | process.nextTick(function() { | |
0 commit comments