Commit 4128eef
src: remove ignore GCC -Wcast-function-type for v8
This reverts Commit 3ff2aec ("src:
ignore GCC -Wcast-function-type for v8.h") and Commit
2462a2c ("src: fix ignore GCC
-Wcast-function-type for older compilers") as this has
now been included in the V8 version being used.
PR-URL: #35768
Refs: v8/v8@f08cbfd
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>1 parent 4b8b5fe commit 4128eef
3 files changed
Lines changed: 0 additions & 21 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -28,14 +28,7 @@ | |||
| 28 | 28 | #include "env-inl.h" | |
| 29 | 29 | #include "util.h" | |
| 30 | 30 | ||
| 31 | - #if (__GNUC__ >= 8) && !defined(__clang__) | ||
| 32 | - #pragma GCC diagnostic push | ||
| 33 | - #pragma GCC diagnostic ignored "-Wcast-function-type" | ||
| 34 | - #endif | ||
| 35 | 31 | #include "v8.h" | |
| 36 | - #if (__GNUC__ >= 8) && !defined(__clang__) | ||
| 37 | - #pragma GCC diagnostic pop | ||
| 38 | - #endif | ||
| 39 | 32 | ||
| 40 | 33 | namespace node { | |
| 41 | 34 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -60,14 +60,7 @@ | |||
| 60 | 60 | # define SIGKILL 9 | |
| 61 | 61 | #endif | |
| 62 | 62 | ||
| 63 | - #if (__GNUC__ >= 8) && !defined(__clang__) | ||
| 64 | - #pragma GCC diagnostic push | ||
| 65 | - #pragma GCC diagnostic ignored "-Wcast-function-type" | ||
| 66 | - #endif | ||
| 67 | 63 | #include "v8.h" // NOLINT(build/include_order) | |
| 68 | - #if (__GNUC__ >= 8) && !defined(__clang__) | ||
| 69 | - #pragma GCC diagnostic pop | ||
| 70 | - #endif | ||
| 71 | 64 | ||
| 72 | 65 | #include "v8-platform.h" // NOLINT(build/include_order) | |
| 73 | 66 | #include "node_version.h" // NODE_MODULE_VERSION | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -24,14 +24,7 @@ | |||
| 24 | 24 | ||
| 25 | 25 | #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS | |
| 26 | 26 | ||
| 27 | - #if (__GNUC__ >= 8) && !defined(__clang__) | ||
| 28 | - #pragma GCC diagnostic push | ||
| 29 | - #pragma GCC diagnostic ignored "-Wcast-function-type" | ||
| 30 | - #endif | ||
| 31 | 27 | #include "v8.h" | |
| 32 | - #if (__GNUC__ >= 8) && !defined(__clang__) | ||
| 33 | - #pragma GCC diagnostic pop | ||
| 34 | - #endif | ||
| 35 | 28 | ||
| 36 | 29 | #include <climits> | |
| 37 | 30 | #include <cstddef> | |
0 commit comments