Commit 4182e3b
deps: patch V8 to run on older XCode versions
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
property, which is a fairly new C++ feature, since that requires a newer
XCode version than the minimum requirement in BUILDING.md and thus
breaks CI.
Backport-PR-URL: #30513
PR-URL: #29694
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>1 parent 6566c15 commit 4182e3b
3 files changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -39,7 +39,7 @@ | |||
| 39 | 39 | ||
| 40 | 40 | # Reset this number to 0 on major V8 upgrades. | |
| 41 | 41 | # Increment by one for each non-official patch applied to deps/v8. | |
| 42 | - 'v8_embedder_string': '-node.2', | ||
| 42 | + 'v8_embedder_string': '-node.3', | ||
| 43 | 43 | ||
| 44 | 44 | ##### V8 defaults for Node.js ##### | |
| 45 | 45 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4203,6 +4203,7 @@ GlobalAccessFeedback::GlobalAccessFeedback(PropertyCellRef cell, | |||
| 4203 | 4203 | ||
| 4204 | 4204 | GlobalAccessFeedback::GlobalAccessFeedback(FeedbackSlotKind slot_kind) | |
| 4205 | 4205 | : ProcessedFeedback(kGlobalAccess, slot_kind), | |
| 4206 | + cell_or_context_(base::nullopt), | ||
| 4206 | 4207 | index_and_immutable_(0 /* doesn't matter */) { | |
| 4207 | 4208 | DCHECK(IsGlobalICKind(slot_kind)); | |
| 4208 | 4209 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -280,7 +280,7 @@ Interpreter::NewSourcePositionCollectionJob( | |||
| 280 | 280 | auto job = std::make_unique<InterpreterCompilationJob>(parse_info, literal, | |
| 281 | 281 | allocator, nullptr); | |
| 282 | 282 | job->compilation_info()->SetBytecodeArray(existing_bytecode); | |
| 283 | - return job; | ||
| 283 | + return std::unique_ptr<UnoptimizedCompilationJob> { static_cast<UnoptimizedCompilationJob*>(job.release()) }; | ||
| 284 | 284 | } | |
| 285 | 285 | ||
| 286 | 286 | void Interpreter::ForEachBytecode( | |
0 commit comments