Commit 4221b1c
src: fix null deref in AllocatedBuffer::clear
An empty buffer can have a null environment. Previously, we were
getting away with with this, but -fsanitize=null in clang caught it.
PR-URL: #32892
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>1 parent fa71073 commit 4221b1c
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -995,7 +995,10 @@ inline AllocatedBuffer::~AllocatedBuffer() { | |||
| 995 | 995 | ||
| 996 | 996 | inline void AllocatedBuffer::clear() { | |
| 997 | 997 | uv_buf_t buf = release(); | |
| 998 | - env_->Free(buf.base, buf.len); | ||
| 998 | + if (buf.base != nullptr) { | ||
| 999 | + CHECK_NOT_NULL(env_); | ||
| 1000 | + env_->Free(buf.base, buf.len); | ||
| 1001 | + } | ||
| 999 | 1002 | } | |
| 1000 | 1003 | ||
| 1001 | 1004 | // It's a bit awkward to define this Buffer::New() overload here, but it | |
0 commit comments