Commit 42b4f3c
src: fix abort when taking a heap snapshot
Remove an erroneous CHECK that asserted the persistent object's internal
field pointer still pointed to a valid object. If ClearWrap() has been
called, the field pointer equals nullptr and that is expected behavior.
PR-URL: #18898
Fixes: #18256
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matheus Marchini <matheus@sthima.com>1 parent 29c395d commit 42b4f3c
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -129,7 +129,7 @@ RetainedObjectInfo* WrapperInfo(uint16_t class_id, Local<Value> wrapper) { | |||
| 129 | 129 | CHECK_GT(object->InternalFieldCount(), 0); | |
| 130 | 130 | ||
| 131 | 131 | AsyncWrap* wrap = Unwrap<AsyncWrap>(object); | |
| 132 | - CHECK_NE(nullptr, wrap); | ||
| 132 | + if (wrap == nullptr) return nullptr; // ClearWrap() already called. | ||
| 133 | 133 | ||
| 134 | 134 | return new RetainedAsyncInfo(class_id, wrap); | |
| 135 | 135 | } | |
0 commit comments