Commit 42ff6d9
src: print native module id on native module not found
To help core contributors identify which file is missing from the build.
PR-URL: #39460
Refs: #39408
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent e4331cd commit 42ff6d9
1 file changed
Lines changed: 4 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -224,7 +224,10 @@ MaybeLocal<String> NativeModuleLoader::LoadBuiltinModuleSource(Isolate* isolate, | |||
| 224 | 224 | isolate, contents.c_str(), v8::NewStringType::kNormal, contents.length()); | |
| 225 | 225 | #else | |
| 226 | 226 | const auto source_it = source_.find(id); | |
| 227 | - CHECK_NE(source_it, source_.end()); | ||
| 227 | + if (UNLIKELY(source_it == source_.end())) { | ||
| 228 | + fprintf(stderr, "Cannot find native builtin: \"%s\".\n", id); | ||
| 229 | + ABORT(); | ||
| 230 | + } | ||
| 228 | 231 | return source_it->second.ToStringChecked(isolate); | |
| 229 | 232 | #endif // NODE_BUILTIN_MODULES_PATH | |
| 230 | 233 | } | |
0 commit comments