Commit 4356836
fs: validate writev fds consistently
This commit updates the recently added writev methods
to validate file descriptors like the other fs methods do.
PR-URL: #29185
Refs: #25925
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>1 parent acdc21b commit 4356836
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -609,7 +609,7 @@ function writev(fd, buffers, position, callback) { | |||
| 609 | 609 | callback(err, written || 0, buffers); | |
| 610 | 610 | } | |
| 611 | 611 | ||
| 612 | - validateUint32(fd, 'fd'); | ||
| 612 | + validateInt32(fd, 'fd', 0); | ||
| 613 | 613 | ||
| 614 | 614 | if (!isBuffersArray(buffers)) { | |
| 615 | 615 | throw new ERR_INVALID_ARG_TYPE('buffers', 'ArrayBufferView[]', buffers); | |
@@ -634,7 +634,7 @@ Object.defineProperty(writev, internalUtil.customPromisifyArgs, { | |||
| 634 | 634 | // fs.writevSync(fd, buffers[, position]); | |
| 635 | 635 | function writevSync(fd, buffers, position) { | |
| 636 | 636 | ||
| 637 | - validateUint32(fd, 'fd'); | ||
| 637 | + validateInt32(fd, 'fd', 0); | ||
| 638 | 638 | const ctx = {}; | |
| 639 | 639 | ||
| 640 | 640 | if (!isBuffersArray(buffers)) { | |
0 commit comments