src: move `napi_addon_register_func` to `node_api_types.h` · nodejs/node@4385b0b · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 4385b0b

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

aduh95

committed

src: move napi_addon_register_func to node_api_types.h

This means that `node.h` can include only this file, instead of the entirety of `node_api.h`. Split out from #60496 since it was rightfully pointed out that the breaking part of the change should not touch Node-API headers. PR-URL: #60512 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent de78da7 commit 4385b0b
Copy full SHA for 4385b0b

2 files changed

+4-4Lines changed: 4 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_api.h
  • node_api_types.h

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_api.h‎

Copy file name to clipboardExpand all lines: src/node_api.h

-4Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -33,10 +33,6 @@ struct uv_loop_s; // Forward declaration.
33	33	#define NAPI_NO_RETURN
34	34	#endif
35	35
36		- typedef napi_value(NAPI_CDECL* napi_addon_register_func)(napi_env env,
37		- napi_value exports);
38		- typedef int32_t(NAPI_CDECL* node_api_addon_get_api_version_func)(void);
39		-
40	36	// Used by deprecated registration method napi_module_register.
41	37	typedef struct napi_module {
42	38	int nm_version;

Collapse file

‎src/node_api_types.h‎

Copy file name to clipboardExpand all lines: src/node_api_types.h

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -3,6 +3,10 @@
3	3
4	4	#include "js_native_api_types.h"
5	5
	6	+ typedef napi_value(NAPI_CDECL* napi_addon_register_func)(napi_env env,
	7	+ napi_value exports);
	8	+ typedef int32_t(NAPI_CDECL* node_api_addon_get_api_version_func)(void);
	9	+
6	10	typedef struct napi_callback_scope__* napi_callback_scope;
7	11	typedef struct napi_async_context__* napi_async_context;
8	12	typedef struct napi_async_work__* napi_async_work;

0 commit comments

Comments

0 (0)