build: do not include custom ESLint rules testing in tarball · nodejs/node@43e6e54 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 43e6e54

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

targos

committed

build: do not include custom ESLint rules testing in tarball

PR-URL: #59809 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent e17c737 commit 43e6e54
Copy full SHA for 43e6e54

2 files changed

+1-10Lines changed: 1 addition & 10 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .github/workflows
  • build-tarball.yml
• Makefile

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.github/workflows/build-tarball.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/build-tarball.yml

-10Lines changed: 0 additions & 10 deletions

Original file line number	Diff line number	Diff line change
@@ -94,15 +94,5 @@ jobs:
94	94	echo "TAR_DIR=$RUNNER_TEMP/$(basename tarballs/*.tar.gz .tar.gz)" >> "$GITHUB_ENV"
95	95	- name: Build
96	96	run: make -C "$TAR_DIR" build-ci -j4 V=1
97		- - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
98		- with:
99		- persist-credentials: false
100		- sparse-checkout: |
101		- tools/eslint
102		- tools/eslint-rules
103		- - name: Move directories needed for testing
104		- run: |
105		- mv tools/eslint "$TAR_DIR/tools"
106		- mv tools/eslint-rules "$TAR_DIR/tools"
107	97	- name: Test
108	98	run: make -C "$TAR_DIR" run-ci -j4 V=1 TEST_CI_ARGS="-p dots --measure-flakiness 9"

Collapse file

‎Makefile‎

Copy file name to clipboardExpand all lines: Makefile

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -1227,6 +1227,7 @@ $(TARBALL): release-only doc-only
1227	1227	$(RM) -r $(TARNAME)/tools/cpplint.py
1228	1228	$(RM) -r $(TARNAME)/tools/eslint
1229	1229	$(RM) -r $(TARNAME)/tools/eslint-rules
	1230	+ $(RM) -r $(TARNAME)/test/parallel/test-eslint-*
1230	1231	$(RM) -r $(TARNAME)/tools/license-builder.sh
1231	1232	$(RM) -r $(TARNAME)/tools/eslint/node_modules
1232	1233	$(RM) -r $(TARNAME)/tools/osx-*

0 commit comments

Comments

0 (0)