Commit 43ede1a
test: mark 'test/parallel/test-sqlite.js' as flaky
The current test is large and can time out. It should be split
into multiple smaller tests as done in #54014. However, that
approach appears to change GC behavior such that the database
files are not cleaned up quickly enough on Windows. Forcing
any unfinalized SQL statements to be GC'ed appears to fix the
problem. Mark the original test as flaky until the necessary
code changes are made.
PR-URL: #54031
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent 0d70c79 commit 43ede1a
1 file changed
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -19,6 +19,9 @@ test-fs-read-stream-concurrent-reads: PASS, FLAKY | |||
| 19 | 19 | # https://github.com/nodejs/node/issues/52630 | |
| 20 | 20 | test-error-serdes: PASS, FLAKY | |
| 21 | 21 | ||
| 22 | + # https://github.com/nodejs/node/issues/54006 | ||
| 23 | + test-sqlite: PASS, FLAKY | ||
| 24 | + | ||
| 22 | 25 | [$system==win32] | |
| 23 | 26 | ||
| 24 | 27 | # Windows on x86 | |
0 commit comments