Commit 43fd474
build: configure byte order for mips targets
The build defaulted to the byte order of the host system but
that can be different from the endianness of the target system.
Refs: #33703 (comment)
PR-URL: #33898
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent b894df8 commit 43fd474
1 file changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1012,12 +1012,14 @@ def configure_arm(o): | |||
| 1012 | 1012 | o['variables']['arm_fpu'] = options.arm_fpu or arm_fpu | |
| 1013 | 1013 | ||
| 1014 | 1014 | ||
| 1015 | - def configure_mips(o): | ||
| 1015 | + def configure_mips(o, target_arch): | ||
| 1016 | 1016 | can_use_fpu_instructions = (options.mips_float_abi != 'soft') | |
| 1017 | 1017 | o['variables']['v8_can_use_fpu_instructions'] = b(can_use_fpu_instructions) | |
| 1018 | 1018 | o['variables']['v8_use_mips_abi_hardfloat'] = b(can_use_fpu_instructions) | |
| 1019 | 1019 | o['variables']['mips_arch_variant'] = options.mips_arch_variant | |
| 1020 | 1020 | o['variables']['mips_fpu_mode'] = options.mips_fpu_mode | |
| 1021 | + host_byteorder = 'little' if target_arch in ('mipsel', 'mips64el') else 'big' | ||
| 1022 | + o['variables']['v8_host_byteorder'] = host_byteorder | ||
| 1021 | 1023 | ||
| 1022 | 1024 | ||
| 1023 | 1025 | def gcc_version_ge(version_checked): | |
@@ -1077,7 +1079,7 @@ def configure_node(o): | |||
| 1077 | 1079 | if target_arch == 'arm': | |
| 1078 | 1080 | configure_arm(o) | |
| 1079 | 1081 | elif target_arch in ('mips', 'mipsel', 'mips64el'): | |
| 1080 | - configure_mips(o) | ||
| 1082 | + configure_mips(o, target_arch) | ||
| 1081 | 1083 | ||
| 1082 | 1084 | if flavor == 'aix': | |
| 1083 | 1085 | o['variables']['node_target_type'] = 'static_library' | |
0 commit comments