Commit 449d9ec
src: add "missing" bash completion options
Currently, when using the bash completions for node the normal
completions for filenames directories do not work. For example, after
finding a node completion and then wanting to use tab completion
for a filename in the test directory, it is only possible to get the
name of the test directory completed, followed by a space. What is
expected is to be able to continue with tab completion for directories.
This commit adds options to the complete command to enable default bash
completions.
PR-URL: #33744
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>1 parent abf04b2 commit 449d9ec
2 files changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -833,7 +833,8 @@ std::string GetBashCompletion() { | |||
| 833 | 833 | " return 0\n" | |
| 834 | 834 | " fi\n" | |
| 835 | 835 | "}\n" | |
| 836 | - "complete -F _node_complete node node_g"; | ||
| 836 | + "complete -o filenames -o nospace -o bashdefault " | ||
| 837 | + "-F _node_complete node node_g"; | ||
| 837 | 838 | return out.str(); | |
| 838 | 839 | } | |
| 839 | 840 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -24,7 +24,8 @@ const suffix = `' -- "\${cur_word}") ) | |||
| 24 | 24 | return 0 | |
| 25 | 25 | fi | |
| 26 | 26 | } | |
| 27 | - complete -F _node_complete node node_g`.replace(/\r/g, ''); | ||
| 27 | + complete -o filenames -o nospace -o bashdefault -F _node_complete node node_g` | ||
| 28 | + .replace(/\r/g, ''); | ||
| 28 | 29 | ||
| 29 | 30 | assert.ok( | |
| 30 | 31 | output.includes(prefix), | |
0 commit comments