Commit 44b0e13
perf_hooks,trace_events: use stricter equality
There is no need to use loose equality on these checks because
undefined is caught by the preceding typeof check.
PR-URL: #28166
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>1 parent 7a4a94a commit 44b0e13
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -332,7 +332,7 @@ class PerformanceObserver extends AsyncResource { | |||
| 332 | 332 | } | |
| 333 | 333 | ||
| 334 | 334 | observe(options) { | |
| 335 | - if (typeof options !== 'object' || options == null) { | ||
| 335 | + if (typeof options !== 'object' || options === null) { | ||
| 336 | 336 | throw new ERR_INVALID_ARG_TYPE('options', 'Object', options); | |
| 337 | 337 | } | |
| 338 | 338 | if (!Array.isArray(options.entryTypes)) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -73,7 +73,7 @@ class Tracing { | |||
| 73 | 73 | } | |
| 74 | 74 | ||
| 75 | 75 | function createTracing(options) { | |
| 76 | - if (typeof options !== 'object' || options == null) | ||
| 76 | + if (typeof options !== 'object' || options === null) | ||
| 77 | 77 | throw new ERR_INVALID_ARG_TYPE('options', 'object', options); | |
| 78 | 78 | ||
| 79 | 79 | if (!Array.isArray(options.categories)) { | |
0 commit comments