lib: use StringPrototypeStartsWith from primordials in locks · nodejs/node@44b1927 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 44b1927

Browse filesBrowse the repository at this point in the historyBrowse files

kimtaejin3

authored and

aduh95

committed

lib: use StringPrototypeStartsWith from primordials in locks

Use StringPrototypeStartsWith from primordials instead of String.prototype.startsWith to prevent prototype pollution. Refs: #59699 PR-URL: #61492 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

1 parent 3d68811 commit 44b1927
Copy full SHA for 44b1927

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • locks.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/locks.js‎

Copy file name to clipboardExpand all lines: lib/internal/locks.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -159,7 +159,7 @@ class LockManager {
159	159	signal.throwIfAborted();
160	160	}
161	161
162		- if (name.startsWith('-')) {
	162	+ if (name[0] === '-') {
163	163	// If name starts with U+002D HYPHEN-MINUS (-), then reject promise with a
164	164	// "NotSupportedError" DOMException.
165	165	throw lazyDOMException('Lock name may not start with hyphen',

0 commit comments

Comments

0 (0)