test: use one-off agent in http consumed timeout test · nodejs/node@44b4fe4 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 44b4fe4

Browse filesBrowse the repository at this point in the historyBrowse files

trivikr

authored and

aduh95

committed

test: use one-off agent in http consumed timeout test

Disable connection pooling for the client request so server.close() does not wait on an idle keep-alive socket before retrying the test. This keeps the test focused on request timeout behavior instead of HTTP keep-alive teardown timing. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: #64052 Refs: https://github.com/nodejs/reliability/issues?q=%22test-http-server-consumed-timeout%22 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>

1 parent 2f47fb2 commit 44b4fe4
Copy full SHA for 44b4fe4

1 file changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-http-server-consumed-timeout.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-http-server-consumed-timeout.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-server-consumed-timeout.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -58,7 +58,8 @@ function runTest(timeoutDuration) {
58	58	server.listen(0, common.mustCall(() => {
59	59	const req = http.request({
60	60	port: server.address().port,
61		- method: 'POST'
	61	+ method: 'POST',
	62	+ agent: false,
62	63	}, () => {
63	64	let lastIntervalTimestamp = Date.now();
64	65	const interval = setInterval(() => {

0 commit comments

Comments

0 (0)