test: fix cctest URLTest.ToFilePath on Win32 without Intl · nodejs/node@44bcc1d · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 44bcc1d

Browse filesBrowse the repository at this point in the historyBrowse files

jasnell

authored and

targos

committed

test: fix cctest URLTest.ToFilePath on Win32 without Intl

Skip one specific test that requires ICU Fixes: #19051 PR-URL: #22265 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

1 parent dec42b5 commit 44bcc1d
Copy full SHA for 44bcc1d

1 file changed

+5Lines changed: 5 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/cctest
  • test_url.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/cctest/test_url.cc‎

Copy file name to clipboardExpand all lines: test/cctest/test_url.cc

+5Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -88,7 +88,12 @@ TEST_F(URLTest, ToFilePath) {
88	88	T("file:///C:/Program%20Files/", "C:\\Program Files\\");
89	89	T("file:///C:/a/b/c?query#fragment", "C:\\a\\b\\c");
90	90	T("file://host/path/a/b/c?query#fragment", "\\\\host\\path\\a\\b\\c");
	91	+ #if defined(NODE_HAVE_I18N_SUPPORT)
91	92	T("file://xn--weird-prdj8vva.com/host/a", "\\\\wͪ͊eiͬ͋rd.com\\host\\a");
	93	+ #else
	94	+ T("file://xn--weird-prdj8vva.com/host/a",
	95	+ "\\\\xn--weird-prdj8vva.com\\host\\a");
	96	+ #endif
92	97	T("file:///C:/a%2Fb", "");
93	98	T("file:///", "");
94	99	T("file:///home", "");

0 commit comments

Comments

0 (0)