Commit 456f76a
test: remove flag for test-addon-uv-handle-leak
test-addon-uv-handle-leak only requires worker_threads for the
subprocess which it explicitly calls with --experimental-worker. The
main test itself does not need it. Remove Flags: comment and move
loading of worker_threads into subprocess-only logic.
PR-URL: #25327
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 523872b commit 456f76a
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,11 +1,9 @@ | |||
| 1 | - // Flags: --experimental-worker | ||
| 2 | 1 | 'use strict'; | |
| 3 | 2 | const common = require('../common'); | |
| 4 | 3 | const assert = require('assert'); | |
| 5 | 4 | const fs = require('fs'); | |
| 6 | 5 | const path = require('path'); | |
| 7 | 6 | const cp = require('child_process'); | |
| 8 | - const { Worker } = require('worker_threads'); | ||
| 9 | 7 | const { spawnSync } = require('child_process'); | |
| 10 | 8 | ||
| 11 | 9 | // This is a sibling test to test/addons/uv-handle-leak. | |
@@ -19,6 +17,8 @@ if (!fs.existsSync(bindingPath)) | |||
| 19 | 17 | ||
| 20 | 18 | if (process.argv[2] === 'child') { | |
| 21 | 19 | ||
| 20 | + const { Worker } = require('worker_threads'); | ||
| 21 | + | ||
| 22 | 22 | // The worker thread loads and then unloads `bindingPath`. Because of this the | |
| 23 | 23 | // symbols in `bindingPath` are lost when the worker thread quits, but the | |
| 24 | 24 | // number of open handles in the worker thread's event loop is assessed in the | |
0 commit comments