src: add --max-semi-space-size to the options allowed in NODE_OPTIONS · nodejs/node@459d448 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 592
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 459d448

Browse filesBrowse the repository at this point in the historyBrowse files

Emanuel Hoogeveen

authored and

ruyadorno

committed

src: add --max-semi-space-size to the options allowed in NODE_OPTIONS

PR-URL: #44436 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent 7cff1e1 commit 459d448
Copy full SHA for 459d448

3 files changed

+3Lines changed: 3 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • cli.md
• src
  • node_options.cc
• test/parallel
  • test-cli-node-options.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/cli.md‎

Copy file name to clipboardExpand all lines: doc/api/cli.md

+1Lines changed: 1 addition & 0 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -1945,6 +1945,7 @@ V8 options that are allowed are:
1945	1945	* `--interpreted-frames-native-stack`
1946	1946	* `--jitless`
1947	1947	* `--max-old-space-size`
	1948	+ * `--max-semi-space-size`
1948	1949	* `--perf-basic-prof-only-functions`
1949	1950	* `--perf-basic-prof`
1950	1951	* `--perf-prof-unwinding-info`

Collapse file

‎src/node_options.cc‎

Copy file name to clipboardExpand all lines: src/node_options.cc

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -709,6 +709,7 @@ PerIsolateOptionsParser::PerIsolateOptionsParser(
709	709	V8Option{},
710	710	kAllowedInEnvvar);
711	711	AddOption("--max-old-space-size", "", V8Option{}, kAllowedInEnvvar);
	712	+ AddOption("--max-semi-space-size", "", V8Option{}, kAllowedInEnvvar);
712	713	AddOption("--perf-basic-prof", "", V8Option{}, kAllowedInEnvvar);
713	714	AddOption(
714	715	"--perf-basic-prof-only-functions", "", V8Option{}, kAllowedInEnvvar);

Collapse file

‎test/parallel/test-cli-node-options.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-cli-node-options.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -72,6 +72,7 @@ expect('--disallow-code-generation-from-strings', 'B\n');
72	72	expect('--huge-max-old-generation-size', 'B\n');
73	73	expect('--jitless', 'B\n');
74	74	expect('--max-old-space-size=0', 'B\n');
	75	+ expect('--max-semi-space-size=0', 'B\n');
75	76	expect('--stack-trace-limit=100',
76	77	/(\s*at f \(\[(eval|worker eval)\]:1:\d*\)\r?\n)/,
77	78	'(function f() { f(); })();',

0 commit comments

Comments

0 (0)