Commit 4604294
test: make test-console engine agnostic
Do not check the error message if it is generated by the JavaScript
engine (V8, ChakraCore, etc.). Do confirm that it is a `TypeError`.
PR-URL: #16272
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>1 parent 025eadf commit 4604294
1 file changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -42,10 +42,12 @@ assert.doesNotThrow(function() { | |||
| 42 | 42 | console.timeEnd('label'); | |
| 43 | 43 | }); | |
| 44 | 44 | ||
| 45 | + // Check that the `Error` is a `TypeError` but do not check the message as it | ||
| 46 | + // will be different in different JavaScript engines. | ||
| 45 | 47 | assert.throws(() => console.time(Symbol('test')), | |
| 46 | - /^TypeError: Cannot convert a Symbol value to a string$/); | ||
| 48 | + TypeError); | ||
| 47 | 49 | assert.throws(() => console.timeEnd(Symbol('test')), | |
| 48 | - /^TypeError: Cannot convert a Symbol value to a string$/); | ||
| 50 | + TypeError); | ||
| 49 | 51 | ||
| 50 | 52 | ||
| 51 | 53 | // an Object with a custom .inspect() function | |
0 commit comments