test_runner: hide failing tests title when all tests pass · nodejs/node@463361e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 754
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 463361e

Browse filesBrowse the repository at this point in the historyBrowse files

MoLow

authored and

RafaelGSS

committed

test_runner: hide failing tests title when all tests pass

PR-URL: #47370 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent eb837ce commit 463361e
Copy full SHA for 463361e

3 files changed

+19Lines changed: 19 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/test_runner/reporter
  • spec.js
• test/message
  • test_runner_spec_reporter_successful.js
  • test_runner_spec_reporter_successful.out

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/test_runner/reporter/spec.js‎

Copy file name to clipboardExpand all lines: lib/internal/test_runner/reporter/spec.js

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -124,6 +124,10 @@ class SpecReporter extends Transform {
124	124	callback(null, this.#handleEvent({ type, data }));
125	125	}
126	126	_flush(callback) {
	127	+ if (this.#failedTests.length === 0) {
	128	+ callback(null, '');
	129	+ return;
	130	+ }
127	131	const results = [`\n${colors['test:fail']}${symbols['test:fail']}failing tests:${white}\n`];
128	132	for (let i = 0; i < this.#failedTests.length; i++) {
129	133	ArrayPrototypePush(results, this.#formatTestReport(

Collapse file

‎test/message/test_runner_spec_reporter_successful.js‎

Copy file name to clipboard

+6Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,6 @@
	1	+ // Flags: --no-warnings --test-reporter=spec
	2	+ 'use strict';
	3	+ require('../common');
	4	+ const { it } = require('node:test');
	5	+
	6	+ it('should pass', () => {});

Collapse file

‎test/message/test_runner_spec_reporter_successful.out‎

Copy file name to clipboard

+9Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -0,0 +1,9 @@
	1	+ * should pass *(*ms)*
	2	+ *tests 1*
	3	+ *suites 0*
	4	+ *pass 1*
	5	+ *fail 0*
	6	+ *cancelled 0*
	7	+ *skipped 0*
	8	+ *todo 0*
	9	+ *duration_ms *

0 commit comments

Comments

0 (0)