fs: only show deprecation warning when error code matches · nodejs/node@463e585 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 639
• Pull requests 566
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 463e585

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

RafaelGSS

committed

fs: only show deprecation warning when error code matches

PR-URL: #56549 Refs: #55753 Reviewed-By: Jacob Smith <jacob@frende.me>

1 parent 2904e58 commit 463e585
Copy full SHA for 463e585

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib
  • fs.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/fs.js‎

Copy file name to clipboardExpand all lines: lib/fs.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -282,8 +282,8 @@ let showExistsDeprecation = true;
282	282	function existsSync(path) {
283	283	try {
284	284	path = getValidatedPath(path);
285		- } catch {
286		- if (showExistsDeprecation) {
	285	+ } catch (err) {
	286	+ if (showExistsDeprecation && err?.code === 'ERR_INVALID_ARG_TYPE') {
287	287	process.emitWarning(
288	288	'Passing invalid argument types to fs.existsSync is deprecated', 'DeprecationWarning', 'DEP0187',
289	289	);

0 commit comments

Comments

0 (0)