test: remove third argument from call to assert.strictEqual() · nodejs/node@46569d6 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 46569d6

Browse filesBrowse the repository at this point in the historyBrowse files

ForrestWeiswolf

authored and

targos

committed

test: remove third argument from call to assert.strictEqual()

Remove the message argument from call to assert.strictEqual so that the AssertionError will report the value of er.code, and add a comment with the message. PR-URL: #19659 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent e1f44a6 commit 46569d6
Copy full SHA for 46569d6

1 file changed

+3-2Lines changed: 3 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-http-destroyed-socket-write2.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-http-destroyed-socket-write2.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-destroyed-socket-write2.js

+3-2Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -62,12 +62,13 @@ server.listen(0, function() {
62	62	break;
63	63
64	64	default:
	65	+ // Write to a torn down client should RESET or ABORT
65	66	assert.strictEqual(er.code,
66		- 'ECONNRESET',
67		- 'Write to a torn down client should RESET or ABORT');
	67	+ 'ECONNRESET');
68	68	break;
69	69	}
70	70
	71	+
71	72	assert.strictEqual(req.output.length, 0);
72	73	assert.strictEqual(req.outputEncodings.length, 0);
73	74	server.close();

0 commit comments

Comments

0 (0)