Commit 465f2bf
buffer: use Clamp conversion in Blob slice
Align Blob.prototype.slice() with the File API Web IDL definition by
using [Clamp] conversion for the start and end arguments.
This fixes the Blob-slice.any.js WPT expected failures for fractional
start and end values.
Refs: https://www.w3.org/TR/FileAPI/#dfn-Blob
Signed-off-by: HoonDongKang <d159123@naver.com>
PR-URL: #64739
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>1 parent 093098a commit 465f2bf
2 files changed
Lines changed: 2 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -255,11 +255,11 @@ class Blob { | |||
| 255 | 255 | ||
| 256 | 256 | start = converters['long long']( | |
| 257 | 257 | start, | |
| 258 | - { __proto__: null, context: 'start' }, | ||
| 258 | + { __proto__: null, context: 'start', clamp: true }, | ||
| 259 | 259 | ); | |
| 260 | 260 | end = converters['long long']( | |
| 261 | 261 | end, | |
| 262 | - { __proto__: null, context: 'end' }, | ||
| 262 | + { __proto__: null, context: 'end', clamp: true }, | ||
| 263 | 263 | ); | |
| 264 | 264 | ||
| 265 | 265 | if (start < 0) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,16 +36,4 @@ module.exports = { | |||
| 36 | 36 | 'Blob-in-worker.worker.js': { | |
| 37 | 37 | skip: 'Depends on Web Workers API', | |
| 38 | 38 | }, | |
| 39 | - 'Blob-slice.any.js': { | ||
| 40 | - fail: { | ||
| 41 | - expected: [ | ||
| 42 | - 'Slicing test: slice (1,1).', | ||
| 43 | - 'Slicing test: slice (1,3).', | ||
| 44 | - 'Slicing test: slice (1,5).', | ||
| 45 | - 'Slicing test: slice (1,7).', | ||
| 46 | - 'Slicing test: slice (1,8).', | ||
| 47 | - 'Slicing test: slice (1,9).', | ||
| 48 | - ], | ||
| 49 | - }, | ||
| 50 | - }, | ||
| 51 | 39 | }; | |
0 commit comments