Commit 467385a
committed
test: use invalid host according to RFC2606
PR-URL: #14863
Refs: #14781
Refs: https://tools.ietf.org/html/rfc2606#section-2
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>1 parent fd8cf79 commit 467385a
2 files changed
Lines changed: 10 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -388,12 +388,12 @@ TEST(function test_resolveTxt_failure(done) { | |||
| 388 | 388 | ||
| 389 | 389 | ||
| 390 | 390 | TEST(function test_lookup_failure(done) { | |
| 391 | - const req = dns.lookup('does.not.exist', 4, function(err, ip, family) { | ||
| 391 | + const req = dns.lookup('this.hostname.is.invalid', 4, (err, ip, family) => { | ||
| 392 | 392 | assert.ok(err instanceof Error); | |
| 393 | 393 | assert.strictEqual(err.errno, dns.NOTFOUND); | |
| 394 | 394 | assert.strictEqual(err.errno, 'ENOTFOUND'); | |
| 395 | 395 | assert.ok(!/ENOENT/.test(err.message)); | |
| 396 | - assert.ok(/does\.not\.exist/.test(err.message)); | ||
| 396 | + assert.ok(err.message.includes('this.hostname.is.invalid')); | ||
| 397 | 397 | ||
| 398 | 398 | done(); | |
| 399 | 399 | }); | |
@@ -511,11 +511,11 @@ TEST(function test_reverse_failure(done) { | |||
| 511 | 511 | ||
| 512 | 512 | ||
| 513 | 513 | TEST(function test_lookup_failure(done) { | |
| 514 | - const req = dns.lookup('nosuchhostimsure', function(err) { | ||
| 514 | + const req = dns.lookup('this.hostname.is.invalid', (err) => { | ||
| 515 | 515 | assert(err instanceof Error); | |
| 516 | 516 | assert.strictEqual(err.code, 'ENOTFOUND'); // Silly error code... | |
| 517 | - assert.strictEqual(err.hostname, 'nosuchhostimsure'); | ||
| 518 | - assert.ok(/nosuchhostimsure/.test(err.message)); | ||
| 517 | + assert.strictEqual(err.hostname, 'this.hostname.is.invalid'); | ||
| 518 | + assert.ok(err.message.includes('this.hostname.is.invalid')); | ||
| 519 | 519 | ||
| 520 | 520 | done(); | |
| 521 | 521 | }); | |
@@ -525,7 +525,7 @@ TEST(function test_lookup_failure(done) { | |||
| 525 | 525 | ||
| 526 | 526 | ||
| 527 | 527 | TEST(function test_resolve_failure(done) { | |
| 528 | - const req = dns.resolve4('nosuchhostimsure', function(err) { | ||
| 528 | + const req = dns.resolve4('this.hostname.is.invalid', (err) => { | ||
| 529 | 529 | assert(err instanceof Error); | |
| 530 | 530 | ||
| 531 | 531 | switch (err.code) { | |
@@ -537,8 +537,8 @@ TEST(function test_resolve_failure(done) { | |||
| 537 | 537 | break; | |
| 538 | 538 | } | |
| 539 | 539 | ||
| 540 | - assert.strictEqual(err.hostname, 'nosuchhostimsure'); | ||
| 541 | - assert.ok(/nosuchhostimsure/.test(err.message)); | ||
| 540 | + assert.strictEqual(err.hostname, 'this.hostname.is.invalid'); | ||
| 541 | + assert.ok(err.message.includes('this.hostname.is.invalid')); | ||
| 542 | 542 | ||
| 543 | 543 | done(); | |
| 544 | 544 | }); | |
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3,8 +3,8 @@ const assert = require('assert'); | |||
| 3 | 3 | const http = require('http'); | |
| 4 | 4 | const common = require('../common'); | |
| 5 | 5 | ||
| 6 | - // not exists host | ||
| 7 | - const host = '*'.repeat(256); | ||
| 6 | + // Invalid hostname as per https://tools.ietf.org/html/rfc2606#section-2 | ||
| 7 | + const host = 'this.hostname.is.invalid'; | ||
| 8 | 8 | const req = http.get({ host }); | |
| 9 | 9 | const err = new Error('mock unexpected code error'); | |
| 10 | 10 | req.on('error', common.mustCall(() => { | |
0 commit comments