Commit 46b5915
test: skip postmortem metadata test when nm fails
On Windows with msys installation, `nm` is available but
it is not able to grab symbols from the Windows build.
Skipping the test if nm outputs anything to stderr fixes that.
PR-URL: #19107
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 12f19a6 commit 46b5915
1 file changed
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -26,6 +26,11 @@ const nm = spawnSync('nm', args); | |||
| 26 | 26 | if (nm.error && nm.error.errno === 'ENOENT') | |
| 27 | 27 | common.skip('nm not found on system'); | |
| 28 | 28 | ||
| 29 | + const stderr = nm.stderr.toString(); | ||
| 30 | + if (stderr.length > 0) { | ||
| 31 | + common.skip(`Failed to execute nm: ${stderr}`); | ||
| 32 | + } | ||
| 33 | + | ||
| 29 | 34 | const symbolRe = /\s_?(v8dbg_.+)$/; | |
| 30 | 35 | const symbols = nm.stdout.toString().split('\n').reduce((filtered, line) => { | |
| 31 | 36 | const match = line.match(symbolRe); | |
0 commit comments