Commit 46bbabe
test: improve test-stream2-large-read-stall
* use const instead of var
* use assert.strictEqual instead of assert.equal
* use common.mustCall instead of process.on( 'exit', fn )
PR-URL: #10725
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>1 parent 7f04377 commit 46bbabe
1 file changed
Lines changed: 3 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -33,7 +33,9 @@ r.on('readable', function() { | |||
| 33 | 33 | rs.length); | |
| 34 | 34 | }); | |
| 35 | 35 | ||
| 36 | - r.on('end', common.mustCall(function() {})); | ||
| 36 | + r.on('end', common.mustCall(function() { | ||
| 37 | + assert.strictEqual(pushes, PUSHCOUNT + 1); | ||
| 38 | + })); | ||
| 37 | 39 | ||
| 38 | 40 | let pushes = 0; | |
| 39 | 41 | function push() { | |
@@ -49,7 +51,3 @@ function push() { | |||
| 49 | 51 | if (r.push(Buffer.allocUnsafe(PUSHSIZE))) | |
| 50 | 52 | setTimeout(push, 1); | |
| 51 | 53 | } | |
| 52 | - | ||
| 53 | - process.on('exit', function() { | ||
| 54 | - assert.strictEqual(pushes, PUSHCOUNT + 1); | ||
| 55 | - }); | ||
0 commit comments