Commit 46f714f
crypto: check return code from EVP_DigestUpdate
Coverity was complaining that we did not check the
return code. We seem to check in the other place it
is called and the method already handles returning
a result.
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: #41800
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>1 parent 2efe9cb commit 46f714f
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -122,8 +122,7 @@ bool Hash::HashInit(const EVP_MD* md, Maybe<unsigned int> xof_md_len) { | |||
| 122 | 122 | bool Hash::HashUpdate(const char* data, size_t len) { | |
| 123 | 123 | if (!mdctx_) | |
| 124 | 124 | return false; | |
| 125 | - EVP_DigestUpdate(mdctx_.get(), data, len); | ||
| 126 | - return true; | ||
| 125 | + return EVP_DigestUpdate(mdctx_.get(), data, len) == 1; | ||
| 127 | 126 | } | |
| 128 | 127 | ||
| 129 | 128 | void Hash::HashUpdate(const FunctionCallbackInfo<Value>& args) { | |
0 commit comments