Commit 46fb69d
build: build v8 with -fvisibility=hidden on macOS
V8 should be built with -fvisibility=hidden, otherwise
the resulting binary would contain unnecessary symbols. In
particular, on macOS, this leads to 5000+ weak symbols
resolved at runtime, leading to a startup regression.
On macOS this also reduces the binary size about ~10MB.
It's only enabled on macOS in this patch as gcc can time out
or run out of memory on some machines in the CI with
-fvisibility=hidden.
PR-URL: #56275
Fixes: nodejs/performance#180
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>1 parent 7233623 commit 46fb69d
1 file changed
Lines changed: 13 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -41,6 +41,19 @@ | |||
| 41 | 41 | 'AdditionalOptions': ['/utf-8'] | |
| 42 | 42 | } | |
| 43 | 43 | }, | |
| 44 | + 'conditions': [ | ||
| 45 | + ['OS=="mac"', { | ||
| 46 | + # Hide symbols that are not explicitly exported with V8_EXPORT. | ||
| 47 | + # TODO(joyeecheung): enable it on other platforms. Currently gcc times out | ||
| 48 | + # or run out of memory with -fvisibility=hidden on some machines in the CI. | ||
| 49 | + 'xcode_settings': { | ||
| 50 | + 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden | ||
| 51 | + }, | ||
| 52 | + 'defines': [ | ||
| 53 | + 'BUILDING_V8_SHARED', # Make V8_EXPORT visible. | ||
| 54 | + ], | ||
| 55 | + }], | ||
| 56 | + ], | ||
| 44 | 57 | }, | |
| 45 | 58 | 'targets': [ | |
| 46 | 59 | { | |
0 commit comments