Commit 471a5d8
doc: add note re term-size commit on top of npm
Until npm updates update-notifier to a newer version, the dependency
tree will contain a version of term-size that has an unsigned macOS
binary. This will fail .pkg notarization and will result in failed
release builds. We built and signed a term-size and contributed it back
to the project for this purpose, but the dependency chain is long enough
that it's not likely to be included in a new npm very quickly.
Until it is, we need to cherry-pick commit d2f08a1 ontop of any npm
updates to master and any other release branch that includes
notarization.
PR-URL: #32403
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>1 parent 99f260f commit 471a5d8
1 file changed
Lines changed: 18 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -74,7 +74,24 @@ Note: please ensure you are only making the updates that are changed by npm. | |||
| 74 | 74 | $ git rebase --whitespace=fix master | |
| 75 | 75 | ``` | |
| 76 | 76 | ||
| 77 | - ## Step 7: Test the build | ||
| 77 | + ## Step 7: Apply signed term-size commit | ||
| 78 | + | ||
| 79 | + The `term-size` package in npm's dependency tree contains an unsigned macOS | ||
| 80 | + binary in versions < 2.2.0. Until npm updates to a newer version of | ||
| 81 | + `update-notifier`, Node.js macOS package files can't be notarized and will fail | ||
| 82 | + to install on macOS Catalina and above. | ||
| 83 | + | ||
| 84 | + When `npm ls` shows a `term-size` package version < 2.2.0, cherry-pick | ||
| 85 | + commit `d2f08a1bdb` on top of the upgraded npm. | ||
| 86 | + | ||
| 87 | + ```console | ||
| 88 | + $ git cherry-pick d2f08a1bdb | ||
| 89 | + ``` | ||
| 90 | + | ||
| 91 | + When `npm ls` shows a `term-size` package version >= 2.2.0, edit this file to | ||
| 92 | + remove this step. | ||
| 93 | + | ||
| 94 | + ## Step 8: Test the build | ||
| 78 | 95 | ||
| 79 | 96 | ```console | |
| 80 | 97 | $ make test-npm | |
0 commit comments