src: use non-deprecated version of CreateSyntheticModule · nodejs/node@4782818 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 4782818

Browse filesBrowse the repository at this point in the historyBrowse files

targos

committed

src: use non-deprecated version of CreateSyntheticModule

Refs: v8/v8@8ff02b7 PR-URL: #50115 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

1 parent 941cef5 commit 4782818
Copy full SHA for 4782818

1 file changed

+5-2Lines changed: 5 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • module_wrap.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/module_wrap.cc‎

Copy file name to clipboardExpand all lines: src/module_wrap.cc

+5-2Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -35,6 +35,7 @@ using v8::IntegrityLevel;
35	35	using v8::Isolate;
36	36	using v8::Local;
37	37	using v8::MaybeLocal;
	38	+ using v8::MemorySpan;
38	39	using v8::MicrotaskQueue;
39	40	using v8::Module;
40	41	using v8::ModuleRequest;
@@ -170,8 +171,10 @@ void ModuleWrap::New(const FunctionCallbackInfo<Value>& args) {
170	171	export_names[i] = export_name_val.As<String>();
171	172	}
172	173
173		- module = Module::CreateSyntheticModule(isolate, url, export_names,
174		- SyntheticModuleEvaluationStepsCallback);
	174	+ const MemorySpan<const Local<String>> span(export_names.begin(),
	175	+ export_names.size());
	176	+ module = Module::CreateSyntheticModule(
	177	+ isolate, url, span, SyntheticModuleEvaluationStepsCallback);
175	178	} else {
176	179	ScriptCompiler::CachedData* cached_data = nullptr;
177	180	if (!args[5]->IsUndefined()) {

0 commit comments

Comments

0 (0)