esm: throw `ERR_REQUIRE_ESM` instead of `ERR_INTERNAL_ASSERTION` · nodejs/node@4813a6a · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 746
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 4813a6a

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

marco-ippolito

committed

esm: throw ERR_REQUIRE_ESM instead of ERR_INTERNAL_ASSERTION

PR-URL: #54868 Backport-PR-URL: #56927 Fixes: #54773 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Refs: #52697

1 parent d1331fc commit 4813a6a
Copy full SHA for 4813a6a

1 file changed

+3-2Lines changed: 3 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/modules/esm
  • loader.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/modules/esm/loader.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/esm/loader.js

+3-2Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -318,8 +318,6 @@ class ModuleLoader {
318	318	* @returns {ModuleJobBase}
319	319	*/
320	320	getModuleJobForRequire(specifier, parentURL, importAttributes) {
321		- assert(getOptionValue('--experimental-require-module'));
322		-
323	321	const parsed = URLParse(specifier);
324	322	if (parsed != null) {
325	323	const protocol = parsed.protocol;
@@ -338,6 +336,9 @@ class ModuleLoader {
338	336	}
339	337
340	338	const { url, format } = resolveResult;
	339	+ if (!getOptionValue('--experimental-require-module')) {
	340	+ throw new ERR_REQUIRE_ESM(url, true);
	341	+ }
341	342	const resolvedImportAttributes = resolveResult.importAttributes ?? importAttributes;
342	343	let job = this.loadCache.get(url, resolvedImportAttributes.type);
343	344	if (job !== undefined) {

0 commit comments

Comments

0 (0)