Commit 481a901
deps: V8: cherry-pick 0f9ebbc672c7
Original commit message:
[flags] Remove --harmony-string-is-well-formed
The String.prototype.isWellFormed and toWellFormed have shipped
since M111.
Bug: v8:13557
Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Chengzhong Wu (legendecas) <legendecas@gmail.com>
Cr-Commit-Position: refs/heads/main@{#90398}
Refs: v8/v8@0f9ebbc
PR-URL: #50867
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
PR-URL: #50115
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>1 parent 782addb commit 481a901
3 files changed
Lines changed: 5 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.9', | ||
| 39 | + 'v8_embedder_string': '-node.10', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -297,7 +297,6 @@ DEFINE_WEAK_IMPLICATION(harmony_rab_gsab_transfer, harmony_rab_gsab) | |||
| 297 | 297 | #define HARMONY_SHIPPING_BASE(V) \ | |
| 298 | 298 | V(harmony_import_assertions, "harmony import assertions") \ | |
| 299 | 299 | V(harmony_change_array_by_copy, "harmony change-Array-by-copy") \ | |
| 300 | - V(harmony_string_is_well_formed, "harmony String#{is,to}WellFormed") \ | ||
| 301 | 300 | V(harmony_rab_gsab, \ | |
| 302 | 301 | "harmony ResizableArrayBuffer / GrowableSharedArrayBuffer") \ | |
| 303 | 302 | V(harmony_regexp_unicode_sets, "harmony RegExp Unicode Sets") \ | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -2158,6 +2158,8 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object, | |||
| 2158 | 2158 | Builtin::kStringPrototypeIncludes, 1, false); | |
| 2159 | 2159 | SimpleInstallFunction(isolate_, prototype, "indexOf", | |
| 2160 | 2160 | Builtin::kStringPrototypeIndexOf, 1, false); | |
| 2161 | + SimpleInstallFunction(isolate(), prototype, "isWellFormed", | ||
| 2162 | + Builtin::kStringPrototypeIsWellFormed, 0, false); | ||
| 2161 | 2163 | SimpleInstallFunction(isolate_, prototype, "italics", | |
| 2162 | 2164 | Builtin::kStringPrototypeItalics, 0, false); | |
| 2163 | 2165 | SimpleInstallFunction(isolate_, prototype, "lastIndexOf", | |
@@ -2214,6 +2216,8 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object, | |||
| 2214 | 2216 | Builtin::kStringPrototypeStartsWith, 1, false); | |
| 2215 | 2217 | SimpleInstallFunction(isolate_, prototype, "toString", | |
| 2216 | 2218 | Builtin::kStringPrototypeToString, 0, true); | |
| 2219 | + SimpleInstallFunction(isolate(), prototype, "toWellFormed", | ||
| 2220 | + Builtin::kStringPrototypeToWellFormed, 0, false); | ||
| 2217 | 2221 | SimpleInstallFunction(isolate_, prototype, "trim", | |
| 2218 | 2222 | Builtin::kStringPrototypeTrim, 0, false); | |
| 2219 | 2223 | ||
@@ -5068,18 +5072,6 @@ void Genesis::InitializeGlobal_harmony_rab_gsab() { | |||
| 5068 | 5072 | Builtin::kSharedArrayBufferPrototypeGrow, 1, true); | |
| 5069 | 5073 | } | |
| 5070 | 5074 | ||
| 5071 | - void Genesis::InitializeGlobal_harmony_string_is_well_formed() { | ||
| 5072 | - if (!v8_flags.harmony_string_is_well_formed) return; | ||
| 5073 | - Handle<JSFunction> string_function(native_context()->string_function(), | ||
| 5074 | - isolate()); | ||
| 5075 | - Handle<JSObject> string_prototype( | ||
| 5076 | - JSObject::cast(string_function->initial_map()->prototype()), isolate()); | ||
| 5077 | - SimpleInstallFunction(isolate(), string_prototype, "isWellFormed", | ||
| 5078 | - Builtin::kStringPrototypeIsWellFormed, 0, false); | ||
| 5079 | - SimpleInstallFunction(isolate(), string_prototype, "toWellFormed", | ||
| 5080 | - Builtin::kStringPrototypeToWellFormed, 0, false); | ||
| 5081 | - } | ||
| 5082 | - | ||
| 5083 | 5075 | void Genesis::InitializeGlobal_harmony_temporal() { | |
| 5084 | 5076 | if (!v8_flags.harmony_temporal) return; | |
| 5085 | 5077 | // -- T e m p o r a l | |
0 commit comments