tools: make comma-dangle ESLint rule more stringent … · nodejs/node@49013fc · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 746
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 49013fc

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

targos

committed

tools: make comma-dangle ESLint rule more stringent …

We've been having a lot of nits lately asking people to add trailing commas, so it's probably time to incrementally make the comma-dangle rule more stringent. PR-URL: #37088 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent 6205e29 commit 49013fc
Copy full SHA for 49013fc

2 files changed

+9-1Lines changed: 9 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• .eslintrc.js
• test
  • .eslintrc.yaml

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎.eslintrc.js‎

Copy file name to clipboardExpand all lines: .eslintrc.js

+7-1Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -95,7 +95,13 @@ module.exports = {
95	95	ignorePattern: '.*',
96	96	},
97	97	}],
98		- 'comma-dangle': ['error', 'only-multiline'],
	98	+ 'comma-dangle': ['error', {
	99	+ arrays: 'always-multiline',
	100	+ exports: 'only-multiline',
	101	+ functions: 'only-multiline',
	102	+ imports: 'only-multiline',
	103	+ objects: 'only-multiline',
	104	+ }],
99	105	'comma-spacing': 'error',
100	106	'comma-style': 'error',
101	107	'computed-property-spacing': 'error',

Collapse file

‎test/.eslintrc.yaml‎

Copy file name to clipboardExpand all lines: test/.eslintrc.yaml

+2Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -5,6 +5,8 @@ env:
5	5	es6: true
6	6
7	7	rules:
	8	+ # For now, comma-dangle is more lenient in the test directory than elsewhere.
	9	+ comma-dangle: ["error", "only-multiline"]
8	10	no-var: error
9	11	prefer-const: error
10	12	symbol-description: off

0 commit comments

Comments

0 (0)