fs: ensure consistency for mkdtemp in both fs and fs/promises · nodejs/node@490f15a · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 750
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 490f15a

Browse filesBrowse the repository at this point in the historyBrowse files

YieldRay

authored and

marco-ippolito

committed

fs: ensure consistency for mkdtemp in both fs and fs/promises

Port changes for mkdtemp from lib/fs.js to lib/internal/fs/promise.js, ensuring consistent behavior. Refs: #51078 PR-URL: #53776 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>

1 parent bf6aa53 commit 490f15a
Copy full SHA for 490f15a

1 file changed

+1-8Lines changed: 1 addition & 8 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/fs
  • promises.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/fs/promises.js‎

Copy file name to clipboardExpand all lines: lib/internal/fs/promises.js

+1-8Lines changed: 1 addition & 8 deletions

Original file line number	Diff line number	Diff line change
@@ -1179,15 +1179,8 @@ async function mkdtemp(prefix, options) {
1179	1179	prefix = getValidatedPath(prefix, 'prefix');
1180	1180	warnOnNonPortableTemplate(prefix);
1181	1181
1182		- let path;
1183		- if (typeof prefix === 'string') {
1184		- path = `${prefix}XXXXXX`;
1185		- } else {
1186		- path = Buffer.concat([prefix, Buffer.from('XXXXXX')]);
1187		- }
1188		-
1189	1182	return await PromisePrototypeThen(
1190		- binding.mkdtemp(path, options.encoding, kUsePromises),
	1183	+ binding.mkdtemp(prefix, options.encoding, kUsePromises),
1191	1184	undefined,
1192	1185	handleErrorFromBinding,
1193	1186	);

0 commit comments

Comments

0 (0)