Commit 499750f
test: update list of known globals
This is important to allow to run v16 doc tests on more recent versions.
PR-URL: #45255
Refs: https://github.com/nodejs/node/actions/runs/3356902660/jobs/5562322617
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>1 parent 03dcbe3 commit 499750f
1 file changed
Lines changed: 32 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -291,6 +291,9 @@ if (global.gc) { | |||
| 291 | 291 | knownGlobals.push(global.gc); | |
| 292 | 292 | } | |
| 293 | 293 | ||
| 294 | + if (global.Performance) { | ||
| 295 | + knownGlobals.push(global.Performance); | ||
| 296 | + } | ||
| 294 | 297 | if (global.performance) { | |
| 295 | 298 | knownGlobals.push(global.performance); | |
| 296 | 299 | } | |
@@ -301,16 +304,16 @@ if (global.PerformanceMeasure) { | |||
| 301 | 304 | knownGlobals.push(global.PerformanceMeasure); | |
| 302 | 305 | } | |
| 303 | 306 | ||
| 304 | - if (global.fetch) { | ||
| 305 | - knownGlobals.push( | ||
| 306 | - global.fetch, | ||
| 307 | - global.FormData, | ||
| 308 | - global.Request, | ||
| 309 | - global.Response, | ||
| 310 | - global.Headers, | ||
| 311 | - ); | ||
| 307 | + // TODO(@ethan-arrowood): Similar to previous checks, this can be temporary | ||
| 308 | + // until v16.x is EOL. Once all supported versions have structuredClone we | ||
| 309 | + // can add this to the list above instead. | ||
| 310 | + if (global.structuredClone) { | ||
| 311 | + knownGlobals.push(global.structuredClone); | ||
| 312 | 312 | } | |
| 313 | 313 | ||
| 314 | + if (global.fetch) { | ||
| 315 | + knownGlobals.push(fetch); | ||
| 316 | + } | ||
| 314 | 317 | if (hasCrypto && global.crypto) { | |
| 315 | 318 | knownGlobals.push(global.crypto); | |
| 316 | 319 | knownGlobals.push(global.Crypto); | |
@@ -320,6 +323,27 @@ if (hasCrypto && global.crypto) { | |||
| 320 | 323 | if (global.CustomEvent) { | |
| 321 | 324 | knownGlobals.push(global.CustomEvent); | |
| 322 | 325 | } | |
| 326 | + if (global.ReadableStream) { | ||
| 327 | + knownGlobals.push( | ||
| 328 | + global.ReadableStream, | ||
| 329 | + global.ReadableStreamDefaultReader, | ||
| 330 | + global.ReadableStreamBYOBReader, | ||
| 331 | + global.ReadableStreamBYOBRequest, | ||
| 332 | + global.ReadableByteStreamController, | ||
| 333 | + global.ReadableStreamDefaultController, | ||
| 334 | + global.TransformStream, | ||
| 335 | + global.TransformStreamDefaultController, | ||
| 336 | + global.WritableStream, | ||
| 337 | + global.WritableStreamDefaultWriter, | ||
| 338 | + global.WritableStreamDefaultController, | ||
| 339 | + global.ByteLengthQueuingStrategy, | ||
| 340 | + global.CountQueuingStrategy, | ||
| 341 | + global.TextEncoderStream, | ||
| 342 | + global.TextDecoderStream, | ||
| 343 | + global.CompressionStream, | ||
| 344 | + global.DecompressionStream, | ||
| 345 | + ); | ||
| 346 | + } | ||
| 323 | 347 | ||
| 324 | 348 | function allowGlobals(...allowlist) { | |
| 325 | 349 | knownGlobals = knownGlobals.concat(allowlist); | |
0 commit comments