test: increase timeout in vm-timeout-escape-queuemicrotask · nodejs/node@49c959d · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 49c959d

Browse filesBrowse the repository at this point in the historyBrowse files

lundibundi

authored and

codebytere

committed

test: increase timeout in vm-timeout-escape-queuemicrotask

It looks like under high load the loop isn't even started and therefore successfully finishes without 'escaping'. After increasing the timeout during parallel run of the test failure rate decreased from 15/1000 to 0/1000. PR-URL: #31966 Refs: #25529 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent 6adbfac commit 49c959d
Copy full SHA for 49c959d

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/known_issues
  • test-vm-timeout-escape-queuemicrotask.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/known_issues/test-vm-timeout-escape-queuemicrotask.js‎

Copy file name to clipboardExpand all lines: test/known_issues/test-vm-timeout-escape-queuemicrotask.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -12,8 +12,8 @@ const NS_PER_MS = 1000000n;
12	12
13	13	const hrtime = process.hrtime.bigint;
14	14
15		- const loopDuration = common.platformTimeout(100n);
16		- const timeout = common.platformTimeout(10);
	15	+ const loopDuration = common.platformTimeout(1000n);
	16	+ const timeout = common.platformTimeout(100);
17	17
18	18	function loop() {
19	19	const start = hrtime();

0 commit comments

Comments

0 (0)