Commit 49cf345
src: rename misleading arg in ClientHelloParser
Despite being named onend_arg, the pointer is passed both to the
onend_cb and to the onhello_cb. Rename it to cb_arg, which matches the
name of the class field cb_arg_.
PR-URL: #44500
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>1 parent 9a52ee7 commit 49cf345
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -51,7 +51,7 @@ inline void ClientHelloParser::Reset() { | |||
| 51 | 51 | ||
| 52 | 52 | inline void ClientHelloParser::Start(ClientHelloParser::OnHelloCb onhello_cb, | |
| 53 | 53 | ClientHelloParser::OnEndCb onend_cb, | |
| 54 | - void* onend_arg) { | ||
| 54 | + void* cb_arg) { | ||
| 55 | 55 | if (!IsEnded()) | |
| 56 | 56 | return; | |
| 57 | 57 | Reset(); | |
@@ -61,7 +61,7 @@ inline void ClientHelloParser::Start(ClientHelloParser::OnHelloCb onhello_cb, | |||
| 61 | 61 | state_ = kWaiting; | |
| 62 | 62 | onhello_cb_ = onhello_cb; | |
| 63 | 63 | onend_cb_ = onend_cb; | |
| 64 | - cb_arg_ = onend_arg; | ||
| 64 | + cb_arg_ = cb_arg; | ||
| 65 | 65 | } | |
| 66 | 66 | ||
| 67 | 67 | inline void ClientHelloParser::End() { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -66,7 +66,7 @@ class ClientHelloParser { | |||
| 66 | 66 | void Parse(const uint8_t* data, size_t avail); | |
| 67 | 67 | ||
| 68 | 68 | inline void Reset(); | |
| 69 | - inline void Start(OnHelloCb onhello_cb, OnEndCb onend_cb, void* onend_arg); | ||
| 69 | + inline void Start(OnHelloCb onhello_cb, OnEndCb onend_cb, void* cb_arg); | ||
| 70 | 70 | inline void End(); | |
| 71 | 71 | inline bool IsPaused() const; | |
| 72 | 72 | inline bool IsEnded() const; | |
0 commit comments