Commit 49e6f33
test: fix test-http-server-keepalive-req-gc
This changes adds a second explicit gc call in the test. Without this
call, the test relies on gc eventually happening based, since the
first call doesn't free the object.
Relying on gc to eventually happen prevents changing GC heuristics
unrelated to this test.
The gc call is async; otherwise doing multiple sync GCs doesn't free
the object.
PR-URL: #53292
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent d18a67f commit 49e6f33
1 file changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -14,9 +14,10 @@ const server = createServer(common.mustCall((req, res) => { | |||
| 14 | 14 | onGC(req, { ongc: common.mustCall(() => { server.close(); }) }); | |
| 15 | 15 | req.resume(); | |
| 16 | 16 | req.on('end', common.mustCall(() => { | |
| 17 | - setImmediate(() => { | ||
| 17 | + setImmediate(async () => { | ||
| 18 | 18 | client.end(); | |
| 19 | - global.gc(); | ||
| 19 | + await global.gc({ type: 'major', execution: 'async' }); | ||
| 20 | + await global.gc({ type: 'major', execution: 'async' }); | ||
| 20 | 21 | }); | |
| 21 | 22 | })); | |
| 22 | 23 | res.end('hello world'); | |
0 commit comments