FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: http_outgoing rename var to let and const · nodejs/node@4a54f30 · GitHub

/ node Public

Commit 4a54f30

Browse files
telenord
authored and
BridgeAR
committed
http: http_outgoing rename var to let and const
PR-URL: #30284 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent a6c2502 commit 4a54f30

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

‎lib/_http_outgoing.js‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ ObjectDefineProperty(OutgoingMessage.prototype, '_headers', {
168168
const keys = ObjectKeys(val);
169169
// Retain for(;;) loop for performance reasons
170170
// Refs: https://github.com/nodejs/node/pull/30958
171-
for (var i = 0; i < keys.length; ++i) {
171+
for (let i = 0; i < keys.length; ++i) {
172172
const name = keys[i];
173173
headers[name.toLowerCase()] = [name, val[name]];
174174
}
@@ -193,7 +193,7 @@ ObjectDefineProperty(OutgoingMessage.prototype, '_headerNames', {
193193
const keys = ObjectKeys(headers);
194194
// Retain for(;;) loop for performance reasons
195195
// Refs: https://github.com/nodejs/node/pull/30958
196-
for (var i = 0; i < keys.length; ++i) {
196+
for (let i = 0; i < keys.length; ++i) {
197197
const key = keys[i];
198198
const val = headers[key][0];
199199
out[key] = val;
@@ -210,7 +210,7 @@ ObjectDefineProperty(OutgoingMessage.prototype, '_headerNames', {
210210
const keys = ObjectKeys(val);
211211
// Retain for(;;) loop for performance reasons
212212
// Refs: https://github.com/nodejs/node/pull/30958
213-
for (var i = 0; i < keys.length; ++i) {
213+
for (let i = 0; i < keys.length; ++i) {
214214
const header = headers[keys[i]];
215215
if (header)
216216
header[0] = val[keys[i]];
@@ -232,7 +232,7 @@ OutgoingMessage.prototype._renderHeaders = function _renderHeaders() {
232232
const keys = ObjectKeys(headersMap);
233233
// Retain for(;;) loop for performance reasons
234234
// Refs: https://github.com/nodejs/node/pull/30958
235-
for (var i = 0, l = keys.length; i < l; i++) {
235+
for (let i = 0, l = keys.length; i < l; i++) {
236236
const key = keys[i];
237237
headers[headersMap[key][0]] = headersMap[key][1];
238238
}
@@ -297,7 +297,7 @@ OutgoingMessage.prototype._send = function _send(data, encoding, callback) {
297297
(encoding === 'utf8' || encoding === 'latin1' || !encoding)) {
298298
data = this._header + data;
299299
} else {
300-
var header = this._header;
300+
const header = this._header;
301301
if (this.outputData.length === 0) {
302302
this.outputData = [{
303303
data: header,
@@ -468,7 +468,7 @@ function processHeader(self, state, key, value, validate) {
468468
if (value.length < 2 || !isCookieField(key)) {
469469
// Retain for(;;) loop for performance reasons
470470
// Refs: https://github.com/nodejs/node/pull/30958
471-
for (var i = 0; i < value.length; i++)
471+
for (let i = 0; i < value.length; i++)
472472
storeHeader(self, state, key, value[i], validate);
473473
return;
474474
}
@@ -571,7 +571,7 @@ OutgoingMessage.prototype.getHeaders = function getHeaders() {
571571
const keys = ObjectKeys(headers);
572572
// Retain for(;;) loop for performance reasons
573573
// Refs: https://github.com/nodejs/node/pull/30958
574-
for (var i = 0; i < keys.length; ++i) {
574+
for (let i = 0; i < keys.length; ++i) {
575575
const key = keys[i];
576576
const val = headers[key][1];
577577
ret[key] = val;
@@ -676,8 +676,9 @@ function write_(msg, chunk, encoding, callback, fromEnd) {
676676
process.nextTick(connectionCorkNT, msg.socket);
677677
}
678678

679-
var len, ret;
679+
let ret;
680680
if (msg.chunkedEncoding && chunk.length !== 0) {
681+
let len;
681682
if (typeof chunk === 'string')
682683
len = Buffer.byteLength(chunk, encoding);
683684
else
@@ -711,11 +712,11 @@ OutgoingMessage.prototype.addTrailers = function addTrailers(headers) {
711712
this._trailer = '';
712713
const keys = ObjectKeys(headers);
713714
const isArray = ArrayIsArray(headers);
714-
var field, value;
715715
// Retain for(;;) loop for performance reasons
716716
// Refs: https://github.com/nodejs/node/pull/30958
717-
for (var i = 0, l = keys.length; i < l; i++) {
718-
var key = keys[i];
717+
for (let i = 0, l = keys.length; i < l; i++) {
718+
let field, value;
719+
const key = keys[i];
719720
if (isArray) {
720721
field = headers[key][0];
721722
value = headers[key][1];
@@ -839,11 +840,10 @@ OutgoingMessage.prototype._finish = function _finish() {
839840
// to attempt to flush any pending messages out to the socket.
840841
OutgoingMessage.prototype._flush = function _flush() {
841842
const socket = this.socket;
842-
var ret;
843843

844844
if (socket && socket.writable) {
845845
// There might be remaining data in this.output; write it out
846-
ret = this._flushOutput(socket);
846+
const ret = this._flushOutput(socket);
847847

848848
if (this.finished) {
849849
// This is a queue to the server or client to bring in the next this.
@@ -870,7 +870,7 @@ OutgoingMessage.prototype._flushOutput = function _flushOutput(socket) {
870870
let ret;
871871
// Retain for(;;) loop for performance reasons
872872
// Refs: https://github.com/nodejs/node/pull/30958
873-
for (var i = 0; i < outputLength; i++) {
873+
for (let i = 0; i < outputLength; i++) {
874874
const { data, encoding, callback } = outputData[i];
875875
ret = socket.write(data, encoding, callback);
876876
}

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL