node-api: reword "implementation in an alternative VM" as implementable · nodejs/node@4aefcfc · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 4aefcfc

Browse filesBrowse the repository at this point in the historyBrowse files

legendecas

authored and

aduh95

committed

node-api: reword "implementation in an alternative VM" as implementable

PR-URL: #59036 Fixes: #58852 Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

1 parent 4619fe0 commit 4aefcfc
Copy full SHA for 4aefcfc

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/contributing
  • adding-new-napi-api.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/contributing/adding-new-napi-api.md‎

Copy file name to clipboardExpand all lines: doc/contributing/adding-new-napi-api.md

+2-2Lines changed: 2 additions & 2 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -37,7 +37,7 @@ please follow these principles and guidelines:
37	37
38	38	2. **Review and approval**
39	39	* A new API addition **must** be signed off by at least two Node-API team members.
40		- * **Should** be implemented in at least one other VM implementation of Node.js.
	40	+ * **Should** be implemented in terms of available VM APIs in at least one other VM implementation of Node.js.
41	41
42	42	3. **Experimental phase**
43	43	* New APIs **must** be marked as experimental for at least one minor Node.js release before promotion.
@@ -49,4 +49,4 @@ please follow these principles and guidelines:
49	49	* Approval by the Node-API team.
50	50	* Availability of a down-level implementation if backporting is needed.
51	51	* Usage by a published real-world module.
52		- * Implementation in an alternative VM.
	52	+ * Implementable in an alternative VM.

0 commit comments

Comments

0 (0)