http2: propagate abortsignal reason in new AbortError constructor · nodejs/node@4b3bf7e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 4b3bf7e

Browse filesBrowse the repository at this point in the historyBrowse files

jasnell

authored and

danielleadams

committed

http2: propagate abortsignal reason in new AbortError constructor

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #41008 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

1 parent 01e8c15 commit 4b3bf7e
Copy full SHA for 4b3bf7e

1 file changed

+3-1Lines changed: 3 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/http2
  • core.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/http2/core.js‎

Copy file name to clipboardExpand all lines: lib/internal/http2/core.js

+3-1Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -1778,7 +1778,9 @@ class ClientHttp2Session extends Http2Session {
1778	1778	const { signal } = options;
1779	1779	if (signal) {
1780	1780	validateAbortSignal(signal, 'options.signal');
1781		- const aborter = () => stream.destroy(new AbortError());
	1781	+ const aborter = () => {
	1782	+ stream.destroy(new AbortError(undefined, { cause: signal.reason }));
	1783	+ };
1782	1784	if (signal.aborted) {
1783	1785	aborter();
1784	1786	} else {

0 commit comments

Comments

0 (0)