Commit 4be2e87
deps: V8: cherry-pick 7c182bd65f42
Original commit message:
Fix visiblity rules for configs enforced by the latest GN version.
Prior versions of GN had a bug (gn:22) where visibility rules
for configs weren't being enforced properly.
This CL tweaks the visibility settings of some configs to
conform to the latest version.
Change-Id: Ic5d827a1f2774278d3894f67fe52bfca836c0409
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2360909
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69463}
Refs: v8/v8@7c182bd
PR-URL: #39244
Refs: nodejs/build#2696
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent a83b01a commit 4be2e87
3 files changed
Lines changed: 10 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.69', | ||
| 39 | + 'v8_embedder_string': '-node.70', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -308,7 +308,8 @@ v8_toolset_for_shell = "host" | |||
| 308 | 308 | # | |
| 309 | 309 | ||
| 310 | 310 | config("internal_config_base") { | |
| 311 | - visibility = [ ":*" ] # Only targets in this file can depend on this. | ||
| 311 | + # Only targets in this file and its subdirs can depend on this. | ||
| 312 | + visibility = [ "./*" ] | ||
| 312 | 313 | ||
| 313 | 314 | configs = [ ":v8_tracing_config" ] | |
| 314 | 315 | ||
@@ -321,7 +322,8 @@ config("internal_config_base") { | |||
| 321 | 322 | ||
| 322 | 323 | config("internal_config") { | |
| 323 | 324 | defines = [] | |
| 324 | - visibility = [ ":*" ] # Only targets in this file can depend on this. | ||
| 325 | + # Only targets in this file and its subdirs can depend on this. | ||
| 326 | + visibility = [ "./*" ] | ||
| 325 | 327 | ||
| 326 | 328 | configs = [ | |
| 327 | 329 | "//build/config/compiler:wexit_time_destructors", | |
@@ -429,7 +431,8 @@ config("v8_header_features") { | |||
| 429 | 431 | # Put defines here that are only used in our internal files and NEVER in | |
| 430 | 432 | # external headers that embedders (such as chromium and node) might include. | |
| 431 | 433 | config("features") { | |
| 432 | - visibility = [ ":*" ] # Only targets in this file can depend on this. | ||
| 434 | + # Only targets in this file and its subdirs can depend on this. | ||
| 435 | + visibility = [ "./*" ] | ||
| 433 | 436 | ||
| 434 | 437 | defines = [] | |
| 435 | 438 | ||
@@ -559,7 +562,8 @@ config("features") { | |||
| 559 | 562 | } | |
| 560 | 563 | ||
| 561 | 564 | config("toolchain") { | |
| 562 | - visibility = [ ":*" ] # Only targets in this file can depend on this. | ||
| 565 | + # Only targets in this file and its subdirs can depend on this. | ||
| 566 | + visibility = [ "./*" ] | ||
| 563 | 567 | ||
| 564 | 568 | defines = [] | |
| 565 | 569 | cflags = [] | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,7 +5,7 @@ | |||
| 5 | 5 | import("../../gni/v8.gni") | |
| 6 | 6 | ||
| 7 | 7 | config("crdtp_config") { | |
| 8 | - visibility = [ "../../src/inspector:*" ] | ||
| 8 | + visibility = [ "../../src/inspector:*", ":*" ] | ||
| 9 | 9 | configs = [ "../../:internal_config" ] | |
| 10 | 10 | include_dirs = [ "../../include" ] | |
| 11 | 11 | } | |
0 commit comments