Commit 4c23a95
src: fix possible dereference of null pointer
There is a CHECK_NOT_NULL check before dereferencing node_env on
line 710 in the "if" block, but there is no CHECK_NOT_NULL check before
dereferencing node_env on line 721. Maybe it makes sense to put
CHECK_NOT_NULL right after calling the Environment::GetCurrent function.
PR-URL: #58459
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>1 parent 5a917bc commit 4c23a95
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -704,9 +704,9 @@ void napi_module_register_by_symbol(v8::Local<v8::Object> exports, | |||
| 704 | 704 | napi_addon_register_func init, | |
| 705 | 705 | int32_t module_api_version) { | |
| 706 | 706 | node::Environment* node_env = node::Environment::GetCurrent(context); | |
| 707 | + CHECK_NOT_NULL(node_env); | ||
| 707 | 708 | std::string module_filename = ""; | |
| 708 | 709 | if (init == nullptr) { | |
| 709 | - CHECK_NOT_NULL(node_env); | ||
| 710 | 710 | node_env->ThrowError("Module has no declared entry point."); | |
| 711 | 711 | return; | |
| 712 | 712 | } | |
0 commit comments