test: skip in test-buffer-tostring-rangeerror on allocation failure · nodejs/node@4c445a8 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 746
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 4c445a8

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

targos

committed

test: skip in test-buffer-tostring-rangeerror on allocation failure

If the buffer allocation fails due to insufficient memory, there is no point continue testing toString(). PR-URL: #58415 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

1 parent 53cb298 commit 4c445a8
Copy full SHA for 4c445a8

1 file changed

+19-5Lines changed: 19 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-buffer-tostring-rangeerror.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-buffer-tostring-rangeerror.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-buffer-tostring-rangeerror.js

+19-5Lines changed: 19 additions & 5 deletions

Original file line number	Diff line number	Diff line change
@@ -23,8 +23,22 @@ const message = {
23	23	code: 'ERR_STRING_TOO_LONG',
24	24	name: 'Error',
25	25	};
26		- assert.throws(() => Buffer(len).toString('utf8'), message);
27		- assert.throws(() => SlowBuffer(len).toString('utf8'), message);
28		- assert.throws(() => Buffer.alloc(len).toString('utf8'), message);
29		- assert.throws(() => Buffer.allocUnsafe(len).toString('utf8'), message);
30		- assert.throws(() => Buffer.allocUnsafeSlow(len).toString('utf8'), message);
	26	+
	27	+ function test(getBuffer) {
	28	+ let buf;
	29	+ try {
	30	+ buf = getBuffer();
	31	+ } catch (e) {
	32	+ // If the buffer allocation fails, we skip the test.
	33	+ if (e.code === 'ERR_MEMORY_ALLOCATION_FAILED' || /Array buffer allocation failed/.test(e.message)) {
	34	+ return;
	35	+ }
	36	+ }
	37	+ assert.throws(() => { buf.toString('utf8'); }, message);
	38	+ }
	39	+
	40	+ test(() => Buffer(len));
	41	+ test(() => SlowBuffer(len));
	42	+ test(() => Buffer.alloc(len));
	43	+ test(() => Buffer.allocUnsafe(len));
	44	+ test(() => Buffer.allocUnsafeSlow(len));

0 commit comments

Comments

0 (0)