Commit 4c59b60
src: add support for ETW stack walking
V8 supports native stack walking in Windows by providing JIT code
information to ETW (Event Tracing for Windows). But the option to
enable it is not exposed in NodeJS.
Just add command line (and environment variable) support for
--enable-etw-stack-walking, that maps to V8 option of the same name.
Fixes: #46202
PR-URL: #46203
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>1 parent 4ae2492 commit 4c59b60
2 files changed
Lines changed: 7 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1970,6 +1970,7 @@ V8 options that are allowed are: | |||
| 1970 | 1970 | ||
| 1971 | 1971 | * `--abort-on-uncaught-exception` | |
| 1972 | 1972 | * `--disallow-code-generation-from-strings` | |
| 1973 | + * `--enable-etw-stack-walking` | ||
| 1973 | 1974 | * `--huge-max-old-generation-size` | |
| 1974 | 1975 | * `--interpreted-frames-native-stack` | |
| 1975 | 1976 | * `--jitless` | |
@@ -1986,6 +1987,8 @@ V8 options that are allowed are: | |||
| 1986 | 1987 | `--perf-basic-prof-only-functions`, `--perf-basic-prof`, | |
| 1987 | 1988 | `--perf-prof-unwinding-info`, and `--perf-prof` are only available on Linux. | |
| 1988 | 1989 | ||
| 1990 | + `--enable-etw-stack-walking` is only available on Windows. | ||
| 1991 | + | ||
| 1989 | 1992 | ### `NODE_PATH=path[:…]` | |
| 1990 | 1993 | ||
| 1991 | 1994 | <!-- YAML | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -752,6 +752,10 @@ PerIsolateOptionsParser::PerIsolateOptionsParser( | |||
| 752 | 752 | &PerIsolateOptions::report_signal, | |
| 753 | 753 | kAllowedInEnvvar); | |
| 754 | 754 | Implies("--report-signal", "--report-on-signal"); | |
| 755 | + AddOption("--enable-etw-stack-walking", | ||
| 756 | + "provides heap data to ETW Windows native tracing", | ||
| 757 | + V8Option{}, | ||
| 758 | + kAllowedInEnvvar); | ||
| 755 | 759 | ||
| 756 | 760 | AddOption("--experimental-top-level-await", "", NoOp{}, kAllowedInEnvvar); | |
| 757 | 761 | ||
0 commit comments