src: remove unused `contextify_global_private_symbol` · nodejs/node@4e14ed8 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 4e14ed8

Browse filesBrowse the repository at this point in the historyBrowse files

daeyeon

authored and

RafaelGSS

committed

src: remove unused contextify_global_private_symbol

`contextify_global_private_symbol` is no longer used. It was used to hold a new context's global object, but the approach has been changed to hold a ContextifyContext wrapper using `contextify_context_private_symbol`. Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #45128 Refs: #44796 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

1 parent a2620ac commit 4e14ed8
Copy full SHA for 4e14ed8

2 files changed

+6-8Lines changed: 6 additions & 8 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • env_properties.h
• typings/internalBinding
  • util.d.ts

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/env_properties.h‎

Copy file name to clipboardExpand all lines: src/env_properties.h

-1Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -20,7 +20,6 @@
20	20	#define PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES(V) \
21	21	V(arrow_message_private_symbol, "node:arrowMessage") \
22	22	V(contextify_context_private_symbol, "node:contextify:context") \
23		- V(contextify_global_private_symbol, "node:contextify:global") \
24	23	V(decorated_private_symbol, "node:decorated") \
25	24	V(napi_type_tag, "node:napi:type_tag") \
26	25	V(napi_wrapper, "node:napi:wrapper") \

Collapse file

‎typings/internalBinding/util.d.ts‎

Copy file name to clipboardExpand all lines: typings/internalBinding/util.d.ts

+6-7Lines changed: 6 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -8,15 +8,14 @@ declare namespace InternalUtilBinding {
8	8	}
9	9
10	10	declare function InternalBinding(binding: 'util'): {
11		- // PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES, defined in src/env.h
	11	+ // PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES, defined in src/env_properties.h
12	12	arrow_message_private_symbol: 1;
13	13	contextify_context_private_symbol: 2;
14		- contextify_global_private_symbol: 3;
15		- decorated_private_symbol: 4;
16		- napi_type_tag: 5;
17		- napi_wrapper: 6;
18		- untransferable_object_private_symbol: 7;
19		- exiting_aliased_Uint32Array: 8;
	14	+ decorated_private_symbol: 3;
	15	+ napi_type_tag: 4;
	16	+ napi_wrapper: 5;
	17	+ untransferable_object_private_symbol: 6;
	18	+ exiting_aliased_Uint32Array: 7;
20	19
21	20	kPending: 0;
22	21	kFulfilled: 1;

0 commit comments

Comments

0 (0)