Commit 4e742e3
tools: update tooling to work with new macOS CLI …
Using High Sierra and `xcode-select --install` without installing full
Xcode, our build tooling breaks due to faulty regular expressions.
Update the `configure` script in our project root directory to handle
multi-digit version numbers.
`tools/gyp` and `deps/npm/node_modules/node-gyp` still need to be
updated for a complete fix.
PR-URL: #21173
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 78c7d66 commit 4e742e3
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -667,7 +667,7 @@ def get_llvm_version(cc): | |||
| 667 | 667 | ||
| 668 | 668 | def get_xcode_version(cc): | |
| 669 | 669 | return get_version_helper( | |
| 670 | - cc, r"(^Apple LLVM version) ([5-9]\.[0-9]+)") | ||
| 670 | + cc, r"(^Apple LLVM version) ([0-9]+\.[0-9]+)") | ||
| 671 | 671 | ||
| 672 | 672 | def get_gas_version(cc): | |
| 673 | 673 | try: | |
0 commit comments