assert,util: fix deep comparing invalid dates skipping properties · nodejs/node@4ef4f75 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 756
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 4ef4f75

Browse filesBrowse the repository at this point in the historyBrowse files

BridgeAR

authored and

RafaelGSS

committed

assert,util: fix deep comparing invalid dates skipping properties

The property comparison of invalid dates regressed when starting to handle invalid dates as being equal. PR-URL: #61076 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

1 parent c8fccd5 commit 4ef4f75
Copy full SHA for 4ef4f75

2 files changed

+15-4Lines changed: 15 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/util
  • comparisons.js
• test/parallel
  • test-assert-deep.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/util/comparisons.js‎

Copy file name to clipboardExpand all lines: lib/internal/util/comparisons.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -304,9 +304,9 @@ function objectComparisonStart(val1, val2, mode, memos) {
304	304	}
305	305	const time1 = DatePrototypeGetTime(val1);
306	306	const time2 = DatePrototypeGetTime(val2);
307		- if (time1 !== time2) {
308		- // eslint-disable-next-line no-self-compare
309		- return time1 !== time1 && time2 !== time2;
	307	+ // eslint-disable-next-line no-self-compare
	308	+ if (time1 !== time2 && (time1 === time1 || time2 === time2)) {
	309	+ return false;
310	310	}
311	311	} else if (isRegExp(val1)) {
312	312	if (!isRegExp(val2) || !areSimilarRegExps(val1, val2)) {

Collapse file

‎test/parallel/test-assert-deep.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-assert-deep.js

+12-1Lines changed: 12 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -752,7 +752,18 @@ test('Additional tests', () => {
752	752
753	753	assertNotDeepOrStrict(new Date(), new Date(2000, 3, 14));
754	754
755		- assertDeepAndStrictEqual(new Date('foo'), new Date('bar'));
	755	+ {
	756	+ // Invalid dates deep comparison.
	757	+ const date1 = new Date('foo');
	758	+ const date2 = new Date('bar');
	759	+ date1.foo = true;
	760	+ date2.foo = true;
	761	+ assertDeepAndStrictEqual(date1, date2);
	762	+
	763	+ date1.bar = false;
	764	+ date2.bar = true;
	765	+ assertNotDeepOrStrict(date1, date2);
	766	+ }
756	767
757	768	assertDeepAndStrictEqual(/a/, /a/);
758	769	assertDeepAndStrictEqual(/a/g, /a/g);

0 commit comments

Comments

0 (0)