test_runner: use validateStringArray for `timers.enable()` · nodejs/node@4f421b3 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 749
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 4f421b3

Browse filesBrowse the repository at this point in the historyBrowse files

deokjinkim

authored and

targos

committed

test_runner: use validateStringArray for timers.enable()

`apis` which is argument of `timers.enable()` is string array. So use `validatStringArray` instead of `validateArray`. And `options` is optional, so update JSDoc. PR-URL: #49534 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

1 parent 1ac1fe4 commit 4f421b3
Copy full SHA for 4f421b3

2 files changed

+11-3Lines changed: 11 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/test_runner/mock
  • mock_timers.js
• test/parallel
  • test-runner-mock-timers.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/test_runner/mock/mock_timers.js‎

Copy file name to clipboardExpand all lines: lib/internal/test_runner/mock/mock_timers.js

+3-3Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -26,8 +26,8 @@ const {
26	26	} = primordials;
27	27	const {
28	28	validateAbortSignal,
29		- validateArray,
30	29	validateNumber,
	30	+ validateStringArray,
31	31	} = require('internal/validators');
32	32
33	33	const {
@@ -673,7 +673,7 @@ class MockTimers {
673	673	*/
674	674	/**
675	675	* Enables the MockTimers replacing the native timers with the fake ones.
676		- * @param {EnableOptions} options
	676	+ * @param {EnableOptions} [options]
677	677	*/
678	678	enable(options = { __proto__: null, apis: SUPPORTED_APIS, now: 0 }) {
679	679	const internalOptions = { __proto__: null, ...options };
@@ -693,7 +693,7 @@ class MockTimers {
693	693	internalOptions.apis = SUPPORTED_APIS;
694	694	}
695	695
696		- validateArray(internalOptions.apis, 'options.apis');
	696	+ validateStringArray(internalOptions.apis, 'options.apis');
697	697	// Check that the timers passed are supported
698	698	ArrayPrototypeForEach(internalOptions.apis, (timer) => {
699	699	if (!ArrayPrototypeIncludes(SUPPORTED_APIS, timer)) {

Collapse file

‎test/parallel/test-runner-mock-timers.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-runner-mock-timers.js

+8Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -17,6 +17,14 @@ describe('Mock Timers Test Suite', () => {
17	17	});
18	18	});
19	19
	20	+ it('should throw an error if data type of trying to enable a timer is not string', (t) => {
	21	+ assert.throws(() => {
	22	+ t.mock.timers.enable({ apis: [1] });
	23	+ }, {
	24	+ code: 'ERR_INVALID_ARG_TYPE',
	25	+ });
	26	+ });
	27	+
20	28	it('should throw an error if trying to enable a timer twice', (t) => {
21	29	t.mock.timers.enable();
22	30	assert.throws(() => {

0 commit comments

Comments

0 (0)