test: refactored test-http-allow-req-after-204-res to countdown · nodejs/node@4fb0708 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 4fb0708

Browse filesBrowse the repository at this point in the historyBrowse files

mithunsasidharan

authored and

MylesBorins

committed

test: refactored test-http-allow-req-after-204-res to countdown

PR-URL: #17211 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

1 parent ef25de7 commit 4fb0708
Copy full SHA for 4fb0708

2 files changed

+5-8Lines changed: 5 additions & 8 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test
  • common
    • countdown.js
  • parallel
    • test-http-allow-req-after-204-res.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/common/countdown.js‎

Copy file name to clipboardExpand all lines: test/common/countdown.js

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -17,6 +17,7 @@ class Countdown {
17	17	assert(this[kLimit] > 0, 'Countdown expired');
18	18	if (--this[kLimit] === 0)
19	19	this[kCallback]();
	20	+ return this[kLimit];
20	21	}
21	22
22	23	get remaining() {

Collapse file

‎test/parallel/test-http-allow-req-after-204-res.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-http-allow-req-after-204-res.js

+4-8Lines changed: 4 additions & 8 deletions

Original file line number	Diff line number	Diff line change
@@ -23,12 +23,12 @@
23	23	const common = require('../common');
24	24	const http = require('http');
25	25	const assert = require('assert');
	26	+ const Countdown = require('../common/countdown');
26	27
27	28	// first 204 or 304 works, subsequent anything fails
28	29	const codes = [204, 200];
29	30
30		- // Methods don't really matter, but we put in something realistic.
31		- const methods = ['DELETE', 'DELETE'];
	31	+ const countdown = new Countdown(codes.length, () => server.close());
32	32
33	33	const server = http.createServer(common.mustCall((req, res) => {
34	34	const code = codes.shift();
@@ -39,17 +39,13 @@ const server = http.createServer(common.mustCall((req, res) => {
39	39	}, codes.length));
40	40
41	41	function nextRequest() {
42		- const method = methods.shift();
43	42
44		- const request = http.request({
	43	+ const request = http.get({
45	44	port: server.address().port,
46		- method: method,
47	45	path: '/'
48	46	}, common.mustCall((response) => {
49	47	response.on('end', common.mustCall(() => {
50		- if (methods.length === 0) {
51		- server.close();
52		- } else {
	48	+ if (countdown.dec()) {
53	49	// throws error:
54	50	nextRequest();
55	51	// works just fine:

0 commit comments

Comments

0 (0)